Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug fix: zero duration sound #243

Merged
merged 1 commit into from
Sep 12, 2023
Merged

bug fix: zero duration sound #243

merged 1 commit into from
Sep 12, 2023

Conversation

martin-henz
Copy link
Member

Fix regression introduced in #239

Sounds with duration 0 caused error. Now working:

import { play, sine_sound } from 'sound';
play(sine_sound(400, 0));

and

import { play, sine_sound } from 'stereo_sound';
play(sine_sound(400, 0));

RichDom2185
RichDom2185 approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RichDom2185 RichDom2185 merged commit c9ce9df into master Sep 12, 2023
1 check passed
@Cloud7050 Cloud7050 deleted the zero-sound branch November 1, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichDom2185 RichDom2185 RichDom2185 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martin-henz @RichDom2185